Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Reallocate col spacing & add overflow style for status #1756

Closed
wants to merge 1 commit into from
Closed

🐛 Reallocate col spacing & add overflow style for status #1756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion client/src/app/components/IconedStatus.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import "./iconed-status.css";
import React from "react";
import { Flex, FlexItem, Icon, Tooltip } from "@patternfly/react-core";
import { useTranslation } from "react-i18next";
Expand Down Expand Up @@ -175,7 +176,9 @@ export const IconedStatus: React.FC<IIconedStatusProps> = ({
</Icon>
</IconWithOptionalTooltip>
</FlexItem>
<FlexItem>{label || presetProps?.label}</FlexItem>
<FlexItem className="status-label">
{label || presetProps?.label}
</FlexItem>
{(preset === "InheritedReviews" ||
preset === "InheritedAssessments" ||
preset === "InProgressInheritedAssessments" ||
Expand Down
4 changes: 4 additions & 0 deletions client/src/app/components/iconed-status.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
.status-label {
overflow: hidden;
text-overflow: ellipsis;
}
4 changes: 2 additions & 2 deletions client/src/app/components/tests/__snapshots__/StatusIcon.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ exports[`StatusIcon Renders without crashing 1`] = `
</span>
</div>
<div
class=""
class="status-label"
>
terms.notStarted
</div>
Expand All @@ -47,7 +47,7 @@ exports[`StatusIcon Renders without crashing 1`] = `
</span>
</div>
<div
class=""
class="status-label"
>
terms.notStarted
</div>
Expand Down
4 changes: 2 additions & 2 deletions client/src/app/pages/applications/applications-table/applications-table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -880,7 +880,7 @@ export const ApplicationsTable: React.FC = () => {
{application.name}
</Td>
<Td
width={15}
width={10}
modifier="truncate"
{...getTdProps({ columnKey: "businessService" })}
>
Expand Down Expand Up @@ -918,7 +918,7 @@ export const ApplicationsTable: React.FC = () => {
/>
</Td>
<Td
width={10}
width={15}
modifier="truncate"
{...getTdProps({ columnKey: "analysis" })}
>
Expand Down
Loading