✨ Update external provider modules #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawn-hurley
approved these changes
Sep 10, 2024
djzager
approved these changes
Sep 10, 2024
eemcmullan
changed the title
|
Assuming we can get tests to pass, is there any reason to hold this PR @eemcmullan ? It would really be to my benefit to merge this. |
aufi
approved these changes
Sep 24, 2024
Signed-off-by: Emily McMullan <[email protected]>
eemcmullan
force-pushed
the
prov-modules
branch
from
b6778fd
to
122639b
Compare
This was referenced Oct 1, 2024
jmle
pushed a commit
to jmle/analyzer-lsp
that referenced
this pull request
Oct 25, 2024
With the current external provider module names, we cannot import these providers into other projects, such as kantra. Updating the module names to the path inside of the main repo should fix this issue. Signed-off-by: Emily McMullan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current external provider module names, we cannot import these providers into other projects, such as kantra. Updating the module names to the path inside of the main repo should fix this issue.