👻 Add omitempty for Violation Extras #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eemcmullan
force-pushed
the
omit-extras
branch
from
0fa4b5f
to
54f3ef9
Compare
|
@eemcmullan please remove extras fields from the demo-output.yaml and this should be good to go |
pranavgaikwad
changed the title
pranavgaikwad
requested changes
Sep 14, 2023
Signed-off-by: Emily McMullan <[email protected]>
Signed-off-by: Emily McMullan <[email protected]>
eemcmullan
force-pushed
the
omit-extras
branch
from
c8903a0
to
b169ba8
Compare
pranavgaikwad
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://github.com/konveyor-ecosystem/kantra we need to allow an option to generate the reports in JSON. The JSON marshal was failing as this field was leaving an empty map.