✨ do not decompile all JARs, set sourceOnly mode for binaries' #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -147,7 +147,8 @@ func decompile(ctx context.Context, log logr.Logger, archivePath, projectPath st | |||
| } else { | |||
| log.V(8).Info("decompiled file", "file", filePath) | |||
| } | |||
| } else if strings.HasSuffix(f.Name, JavaArchive) || strings.HasSuffix(f.Name, WebArchive) { | |||
| // decompile web archives | |||
| case strings.HasSuffix(f.Name, WebArchive): | |||
There was a problem hiding this comment.
what happens to the JavaArchive?
There was a problem hiding this comment.
@shawn-hurley only the first level Java archives get decompiled, any JARs inside another JAR mean that they are dependencies, we should only be looking at class files only in the first level to avoid decompiling unnecessary everything
There was a problem hiding this comment.
There was a problem hiding this comment.
heard, this make sense, I don't have the full code mapped in my head anymore so just wanted to double check!
Signed-off-by: Pranav Gaikwad <[email protected]>
pranavgaikwad
force-pushed
the
fixBinaryAnalysis
branch
from
8746f7f
to
a56e961
Compare
shawn-hurley
approved these changes
Aug 30, 2023
This was referenced Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.