-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Added jaeger to images so it runs out of the box #297
Conversation
Signed-off-by: Parthiba-Hazra <[email protected]>
Signed-off-by: Parthiba-Hazra <[email protected]>
@Parthiba-Hazra Thank you for your PR! Can we not build Jaeger and directly include the jaeger/all-in-one image? Also, can we remove duplication in demo.Dockerfile and use the binary directly from base layer? |
@pranavgaikwad actually I tried that. I was getting some problem to start the jaeger .. will try that again. I will reach out to you if I need any help. Thank you :) |
Signed-off-by: Parthiba-Hazra <[email protected]>
@pranavgaikwad please review the changes.. sorry for the trouble actually I had to use command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also enable jaeger by default? instead of having users to pass it, now that it's already in the image, it should just work
Signed-off-by: Parthiba-Hazra <[email protected]>
Signed-off-by: Parthiba-Hazra <[email protected]>
@Parthiba-Hazra thank you! appreciate your patience on this. Going to to give this a quick test before merging. |
@shawn-hurley any objection on using jaeger image from docker.io? |
None from me, I am a plus one |
Fixes: #236