🐛 Not to fail when dependency SHA cannot be read from file. #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Parthiba-Hazra <[email protected]>
Signed-off-by: Parthiba-Hazra <[email protected]>
pranavgaikwad
changed the title
provider/internal/java/dependency.go
Outdated
| @@ -258,9 +258,14 @@ func (p *javaServiceClient) parseDepString(dep, localRepoPath string) (provider. | |||
| fp := filepath.Join(localRepoPath, strings.Replace(parts[0], ".", "/", -1), parts[1], d.Version, fmt.Sprintf("%v-%v.jar.sha1", parts[1], d.Version)) | |||
| b, err := os.ReadFile(fp) | |||
| if err != nil { | |||
| return d, err | |||
| // Log the error and continue with the next dependency. | |||
| fmt.Printf("Error reading SHA hash file for dependency %s: %s\n", dep, err) | |||
There was a problem hiding this comment.
can you please change the fmt.Printf with logger instead? See example usage of the provider logger here
That uses info function, we would use the Error() function of the logger instead
There was a problem hiding this comment.
yeah sure ..
Signed-off-by: Parthiba-Hazra <[email protected]>
pranavgaikwad
requested changes
Jul 27, 2023
provider/internal/java/dependency.go
Outdated
| @@ -258,9 +258,14 @@ func (p *javaServiceClient) parseDepString(dep, localRepoPath string) (provider. | |||
| fp := filepath.Join(localRepoPath, strings.Replace(parts[0], ".", "/", -1), parts[1], d.Version, fmt.Sprintf("%v-%v.jar.sha1", parts[1], d.Version)) | |||
| b, err := os.ReadFile(fp) | |||
| if err != nil { | |||
| return d, err | |||
| // Log the error and continue with the next dependency. | |||
| p.log.V(7).Info("Error reading SHA hash file for dependency %s: %s\n", dep, err) | |||
There was a problem hiding this comment.
Suggested change
| p.log.V(7).Info("Error reading SHA hash file for dependency %s: %s\n", dep, err) | |
| p.log.V(5).Error(err, "error reading SHA hash file for dependency", "dep", d.Name) |
There was a problem hiding this comment.
oh my bad .. thanks for the suggestion. will update now
Signed-off-by: Parthiba-Hazra <[email protected]>
pranavgaikwad
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey in failure scenario I set
d.ResolvedIdentifieras an empty string (d.ResolvedIdentifier = "").Let me know if I need to set it to any other value.
I think this is the only function that need to update maybe have to update also
parseMavenDepLinesfunction .. let me know if I am wrong.Issue: #175