fix menu background on non-scrollable page #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for new-sample-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JiriLojda
requested changes
Jun 10, 2024
components/shared/ui/menu.tsx
Outdated
|
|
||
| const handleMenuClick = (menuId: string | number): void => { | ||
| setActiveMenu(menuId === activeMenu ? -1 : menuId); | ||
| }; | ||
|
|
||
| useEffect(() => { | ||
| // set is scrolled to show the menu when scrolling is not possible | ||
| setIsScrolled(document.body.scrollHeight <= window.innerHeight); |
There was a problem hiding this comment.
I don't like mixing the two concepts. You claim that when the page is too short to be scrolled that the page in fact is scrolled with setting this flag to true. I would prefer having a separate constant (ideally not a state, but a memoized constant created during render) indicating whether the page is scrollable or not.
components/shared/ui/menu.tsx
Outdated
| useEffect(() => { | ||
| // set is scrolled to show the menu when scrolling is not possible | ||
| setIsScrolled(document.body.scrollHeight <= window.innerHeight); | ||
| }, [router]); |
There was a problem hiding this comment.
Why do you need the router here? The component doesn't re-mount on navigating somewhere else? Also why do you use the whole router project as a dependency, isn't just the path property enough?
IvanKiral
force-pushed
the
fix_menu_empty_page
branch
from
5256c02
to
55abec1
Compare
IvanKiral
force-pushed
the
fix_menu_empty_page
branch
from
8ffcea5
to
dcc831e
Compare
IvanKiral
force-pushed
the
fix_menu_empty_page
branch
from
dcc831e
to
d21f927
Compare
JiriLojda
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Which issue does this fix? Fixes #62
If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?
Checklist
How to test
If manual testing is required, what are the steps?