Design improvements #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for new-sample-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JiriLojda
requested changes
Nov 20, 2023
|
made the slightest change to rendering of H1 headings to include some top margin. |
|
suggested improvements split into a standalone issue as they revolve solely around refactoring, without any modifications to the actual experience. public release was agreed upon as a priority, therefore I'm merging the branch. any polishes and refactors shall be dealt with as a part of the low prio epic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes some issues with mobile menu, adds transparent background before scrolling, implements zigzag pattern for facts (both components and linked items, applied for stack as a whole, not for each fact in it).
Checklist
How to test
Check top menu functionality in desktop and mobile version, check zigzag pattern on a page with multiple facts/stacks