Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use generator multichoice in callout and visual container #46

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

IvanKiral
Copy link
Contributor

Motivation

Which issue does this fix? Fixes #issue number

If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@IvanKiral IvanKiral requested a review from a team as a code owner October 3, 2023 13:31
@netlify
Copy link

netlify bot commented Oct 3, 2023

Deploy Preview for new-sample-app ready!

Name Link
🔨 Latest commit 4f75376
🔍 Latest deploy log https://app.netlify.com/sites/new-sample-app/deploys/651c2add791ca30008781382
😎 Deploy Preview https://deploy-preview-46--new-sample-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ficto-healthtech ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 2:57pm
ficto-healthtech-qa ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 2:57pm
ficto-imaging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 2:57pm
ficto-imaging-qa ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 2:57pm
ficto-surgical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 2:57pm
ficto-surgical-qa ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 2:57pm

Copy link
Member

@JiriLojda JiriLojda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the CalloutType into another file as it didn't really fit into the perCollection.ts file. Otherwise it looks good.

@JiriLojda JiriLojda merged commit 1d193bc into main Oct 3, 2023
12 checks passed
@JiriLojda JiriLojda deleted the DEVREL-955_use_multichoice_from_generator branch October 3, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants