Web spotlight root in Navigation #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Env variables are only adjusted on Ficto Healthtech for specific branch (for collection mapping). |
JiriLojda
requested changes
Jul 20, 2023
Simply007
force-pushed
the
DEVREL-911/external-collections-link
branch
from
041c43d
to
eb7d447
Compare
Simply007
force-pushed
the
DEVREL-911/external-collections-link
branch
from
46d0e73
to
af4234e
Compare
Simply007
force-pushed
the
DEVREL-911/external-collections-link
branch
from
af4234e
to
1fd8721
Compare
JiriLojda
approved these changes
Jul 21, 2023
There was a problem hiding this comment.
The potential code simplification from removing the hook (and propagation from getStaticProps on every page) would be nice. However, we can wait for the rewrite to the app router which eliminates the need for manual propagation from getStaticProps. I'll leave it to you to decide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Internal link: DEVRE-911
Checklist
How to test
Check the menu on "Ficto HealthText" after switching the "Solution" item of "Navigation" content type - dropdown should be resolved as expected.