-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for MAPI format #45
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanKiral
requested changes
Mar 26, 2024
tests/transfomers/portable-text-transformer/portable-text-transformer.spec.ts
Outdated
Show resolved
Hide resolved
also plz fix lint |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
==========================================
+ Coverage 94.79% 94.80% +0.01%
==========================================
Files 19 19
Lines 365 366 +1
Branches 68 71 +3
==========================================
+ Hits 346 347 +1
Misses 19 19 ☔ View full report in Codecov by Sentry. |
IvanKiral
requested changes
Apr 5, 2024
IvanKiral
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adjusts transformation logic for assets and components/linked items so that their representation in management API can also be parsed and transformed. Adds a new
dataType
attribute toPortableTextComponent
in order to differentiate between components and linked items.Important
HTML attributes on
object
tag are used to differentiate between linked items and components in the rich text.In DAPI,
data-rel
is used with eithercomponent
orlink
value,data-type
isitem
in both casesIn MAPI,
data-type
is used with eitheritem
orcomponent
value,data-rel
is not presentFor simplicity, I unionized all three possible values as a type for
dataType
property, to mirror the API response.Should we consider adding logic to determine whether the representation is DAPI/MAPI and get rid of the redundant third value (i.e. using only
item | component
)?Checklist
How to test
Try transforming an output from management API with all the Kontent.ai specific objects (links, components, linked items, assets...).