Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research&Implement: Use PHP-DI for Dependency Injection #42

Open
2 tasks
petrsvihlik opened this issue Jan 5, 2018 · 0 comments
Open
2 tasks

Research&Implement: Use PHP-DI for Dependency Injection #42

petrsvihlik opened this issue Jan 5, 2018 · 0 comments
Labels
groomed The issue has been groomed and should be in a good shape. hacktoberfest https://hacktoberfest.digitalocean.com/ help wanted refactoring up-for-grabs

Comments

@petrsvihlik
Copy link
Contributor

petrsvihlik commented Jan 5, 2018

Dependencies like typeMapper, propertyMapper, valueConverter, *Factory could be injected using DI. If we implemented DI, we could also have a default container and get rid of method such as getModelBinder.

The goal of this task is to:

  • research whether using a DI framework such as PHP-DI for loading the dependencies in a library such as delivery-sdk-php is a good practice and how it could be implemented properly.
  • either close this issue or implement the DI, based on the findings

Resources:

@petrsvihlik petrsvihlik added this to the 1.5 - Content resolution milestone Jan 5, 2018
@dusekdan dusekdan mentioned this issue Jan 13, 2018
@petrsvihlik petrsvihlik modified the milestones: 1.5 - Content resolution, 2.0 - Personalization Jan 29, 2018
@petrsvihlik petrsvihlik modified the milestone: 2.0 Jun 6, 2018
@petrsvihlik petrsvihlik changed the title Consider using DI Use PHP-DI for Dependency Injection Aug 20, 2018
@petrsvihlik petrsvihlik changed the title Use PHP-DI for Dependency Injection Spike: Use PHP-DI for Dependency Injection Aug 20, 2018
@petrsvihlik petrsvihlik changed the title Spike: Use PHP-DI for Dependency Injection Research&Implement: Use PHP-DI for Dependency Injection Aug 20, 2018
@petrsvihlik petrsvihlik added up-for-grabs groomed The issue has been groomed and should be in a good shape. hacktoberfest https://hacktoberfest.digitalocean.com/ help wanted labels Aug 20, 2018
@petrsvihlik petrsvihlik removed this from the 2.0 milestone Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
groomed The issue has been groomed and should be in a good shape. hacktoberfest https://hacktoberfest.digitalocean.com/ help wanted refactoring up-for-grabs
Projects
None yet
Development

No branches or pull requests

1 participant