Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2nd review #39

Closed
petrsvihlik opened this issue Nov 30, 2017 · 3 comments
Closed

2nd review #39

petrsvihlik opened this issue Nov 30, 2017 · 3 comments
Milestone
1.5 - Content res...

Comments

@petrsvihlik
Copy link
Contributor

  • do a thorough review of the PHP SDK (especially of the content item retrieval/binding part)
@petrsvihlik petrsvihlik added this to the 1.5 - Content resolution milestone Nov 30, 2017
@dusekdan
Copy link
Contributor

dusekdan commented Jan 13, 2018 •
edited
Loading

I started reviewing the code, here is what I have to discuss so far:

I have currently reviewed about 40% of code.

@petrsvihlik
Copy link
Contributor Author

  • you can pass the implementation to public properties of the DeliveryClient right after you construct it... shall we add it to the constructor? or what do you propose?

@Simply007
Copy link
Contributor

@dusekdan closed issue on the board - closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5 - Content resolution
Development

No branches or pull requests
3 participants
@dusekdan @Simply007 @petrsvihlik