Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #110

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix typos #110

wants to merge 1 commit into from

Conversation

andgdk
Copy link
Contributor

@andgdk andgdk commented Dec 13, 2024

Motivation

Correct spelling in readme, commands, symbols, parameters, and tests.
The second commit addresses a build error, as type inference was missing.

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

@andgdk andgdk requested review from JiriLojda and a team as code owners December 13, 2024 19:20
Copy link
Contributor

@IvanKiral IvanKiral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding all the typos! It seems I would need to have Grammarly in my IDE. Left the comments for type interference tho, we don't use any in this codebase unless necessary. Can you please explain why it is needed?

src/modules/sync/diff/workflow.ts Outdated Show resolved Hide resolved
src/modules/sync/diff/language.ts Outdated Show resolved Hide resolved
@andgdk
Copy link
Contributor Author

andgdk commented Dec 18, 2024

Motivation

[...] The second commit addresses a build error, as type inference was missing.

Not sure why this was. I will investigate further and undo those changes.

Correct spelling in readme, commands, symbols, parameters, and tests
@andgdk
Copy link
Contributor Author

andgdk commented Dec 18, 2024

@IvanKiral Made the requested change. Thanks for taking the time to review. I end up with typos myself even with tooling - but yes, can be a life saver :)

@andgdk andgdk requested a review from IvanKiral December 18, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants