add headers to webhook data #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanKiral
force-pushed
the
fix_webhooks_headers
branch
from
1b097e3 to
45cfdd5
Compare
JiriLojda
requested changes
Jan 7, 2025
IvanKiral
force-pushed
the
fix_webhooks_headers
branch
2 times, most recently
from
3f9e1d2 to
d3bfb97
Compare
JiriLojda
force-pushed
the
fix_webhooks_headers
branch
from
368365a to
683b3e2
Compare
JiriLojda
requested changes
Jan 7, 2025
src/utils/files.ts
Outdated
| { | ||
| [DateLevel.Year]: date.getUTCFullYear().toString(), | ||
| [DateLevel.Month]: ("0" + (date.getUTCMonth() + 1)).slice(-2), | ||
| [DateLevel.Day]: ("0" + date.getUTCDate()).slice(-2), |
There was a problem hiding this comment.
We have a function called padWithLeadingZeros in the src/modules/migrations/add.ts module that does exactly this. It would be nice to reuse it.
IvanKiral
force-pushed
the
fix_webhooks_headers
branch
from
7dafee8 to
7a7a2c2
Compare
JiriLojda
requested changes
Jan 7, 2025
tests/unit/utils/number.test.ts
Outdated
| it("should pad the number with leading zeros when numberOfZeros is greater than the length of the number", () => { | ||
| expect(padWithLeadingZeros(5, 3)).toBe("005"); | ||
| expect(padWithLeadingZeros(42, 5)).toBe("00042"); | ||
| expect(padWithLeadingZeros(0, 4)).toBe("0000"); |
There was a problem hiding this comment.
Prefer parametrized tests over one test with multiple expects each for a different case.
tests/unit/utils/files.test.ts
Outdated
| ["2025-02-07-15-08", DateLevel.Minute], | ||
| ["2025-02-07-15-08-40", DateLevel.Second], | ||
| ])( | ||
| "correctly serializes datetime", |
There was a problem hiding this comment.
Include the case data in the test-case name so the cases are distinguishable. Now it is not possible to know which case failed. You can use there printf formatting. https://vitest.dev/api/#test-each
IvanKiral
force-pushed
the
fix_webhooks_headers
branch
from
7a7a2c2 to
e6a0f8e
Compare
IvanKiral
force-pushed
the
fix_webhooks_headers
branch
from
e6a0f8e to
4ec949c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Which issue does this fix? Fixes #
issue numberIf no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?
Checklist
How to test
If manual testing is required, what are the steps?