Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the template repo composable #793

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Conversation

mrsimonemms
Copy link
Contributor

Description

This is a first pass at making the template repo composable and reducing the amount of repetition. There are a few key takeaways from this approach:

  1. it does appear to broadly work, with caveats
  2. we are already inadvertently supporting subtly different configurations. Nothing seems too bad though, but we do need to work on consistency
  3. the k3d setup is very different to the cloud setups, so might prove to be the undoing
  4. the terraform/git* backend setup is going to be very fiddly. This will likely require a fair bit of duplication
  5. there needs to be a way of ignoring files
  6. it may make sense to have a manifest to tell the application how we want to compose the finalised repo

Related Issue(s)

Fixes #773

How to test

This also removes the registries from the templates/<provider>
folders. This is a manual process, but I have confirmed that they are
identical as I've moved them.
This is more of a placeholder, but there needs to be a way of excluding
common files if required. The k3d providers don't have a registry folder,
so a .gitignore might be the way of achieving it. This would need to be
merged in with any other .gitignore folders, so we might need a better way
of achieving this.
This is not a production system, but a useful way to allow gitops-templates
developer to check the files that are generated.
@mrsimonemms mrsimonemms force-pushed the sje/composable-tpls branch 2 times, most recently from 803cf71 to e7c92d4 Compare August 29, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PROPOSAL - refactor the templates to be more composable to reduce the amount of repetition
1 participant