Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vultr installation #787

Closed
wants to merge 3 commits into from
Closed

fix: vultr installation #787

wants to merge 3 commits into from

Conversation

Seven45
Copy link

@Seven45 Seven45 commented Aug 10, 2024

Description

bump kubernetes_version from v1.28.2+1 to v1.28.9+1

Related Issue(s)

Fixes konstructio/kubefirst#2261

How to test

@fharper
Copy link
Contributor

fharper commented Aug 12, 2024

@Seven45 Thanks for the PR, I'll test it today and get back to you.

@jokestax jokestax self-assigned this Aug 12, 2024
@fharper
Copy link
Contributor

fharper commented Aug 12, 2024

FYI, @jokestax is fixing something else for Vultr that need to be fixed before we can test this PR. Once it's done, he will also test this one.

@fharper
Copy link
Contributor

fharper commented Aug 14, 2024

His PR was merged, so I'll be able to test this one.

@fharper fharper assigned fharper and unassigned jokestax Aug 14, 2024
@fharper fharper added the bug Something isn't working label Aug 14, 2024
@fharper
Copy link
Contributor

fharper commented Aug 14, 2024

I'll need to give it another try tomorrow. I had an issue that isn't related to this PR.

@jokestax
Copy link
Contributor

@fharper @Seven45 the issue is fixed in #794

@fharper
Copy link
Contributor

fharper commented Aug 22, 2024

@jokestax: let us know when it's merged so we can test this PR again. Sorry for the delay @Seven45

@jokestax
Copy link
Contributor

@fharper that pr solves the issue,i have upgraded it to 1.30,so you can test that branch itself:)

@fharper
Copy link
Contributor

fharper commented Aug 22, 2024

@Seven45 so sorry but someone else on the team updated the Kubernetes version by fixing another issue, which mean this PR has now no changes, or would have been a version lower than what we decided to use.

I'm so sorry, would have love to merge your commit as a contributor. With that said, thanks a lot for this PR as it helped us find that Vultr wasn't working anymore. We are implementing better daily testing to ensure this does not happen anymore.

Even if I need to close this PR, I consider you a contributor, and would love to send you some swag as a token of our appreciation. Can you ping me on our Slack community (I'm @fred) or by email at [email protected].

@fharper fharper closed this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mismatch kubernetes_version for vultr
3 participants