Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : custom repo for civo #778

Open
wants to merge 146 commits into
base: main
Choose a base branch
from
Open

feat : custom repo for civo #778

wants to merge 146 commits into from

Conversation

jokestax
Copy link
Contributor

we can now deploy multiple repos on same organistation using below flags :

"--gitopsRepoName" metaphorRepoName "adminTeamName" "developerTeamName"

but we have to use kubefirst repo branch "feat-custom-repo" and kubefirst-api repo branch "feat-custom-repo" until its merged into main

@mrsimonemms
Copy link
Contributor

This is quite a large number of files being changed - how can I test it?

@jokestax
Copy link
Contributor Author

This is for all clouds,may be we can distribute the work for testing?

@fharper fharper self-requested a review July 25, 2024 17:55
@fharper
Copy link
Contributor

fharper commented Jul 29, 2024

@jokestax: as a rule of thumb, before asking for review, always try to have your branch up to date with main even if GitHub report no conflict. It only mean there is no code conflict, but other changes can influence yours, and the other way around.

Of course, changes in main can happen after, so in that case, the tester can merge main before testing, or ask you to do it if there are any detected conflicts. It's a best practice, so sharing so you know :)

@jokestax
Copy link
Contributor Author

Okay @fharper ,got it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants