Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ISV-5128): add script to update component sboms #290

Merged
merged 1 commit into from
Nov 1, 2024
Merged

feat(ISV-5128): add script to update component sboms #290

merged 1 commit into from
Nov 1, 2024

Conversation

wcheang
Copy link
Contributor

@wcheang wcheang commented Oct 31, 2024

No description provided.

@wcheang wcheang requested a review from a team as a code owner October 31, 2024 03:59
mmalina
mmalina reviewed Oct 31, 2024
View reviewed changes
sbom/update_component_sbom Outdated Show resolved Hide resolved
mmalina
mmalina reviewed Oct 31, 2024
View reviewed changes
Copy link
Contributor

@mmalina mmalina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only two small comments, but otherwise it looks good.

@wcheang wcheang marked this pull request as draft October 31, 2024 13:24
@wcheang wcheang changed the title wip(ISV-5128): add script to update component sboms feat(ISV-5128): add script to update component sboms Oct 31, 2024
@wcheang wcheang marked this pull request as ready for review October 31, 2024 19:20
mmalina
mmalina previously approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@mmalina mmalina left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to rebase. And now I see there are some Black errors too.

@mmalina mmalina self-requested a review November 1, 2024 09:18
@mmalina mmalina dismissed their stale review November 1, 2024 09:20

Black errors.

@wcheang
Copy link
Contributor Author

wcheang commented Nov 1, 2024

Rebased and ran black on the test file.

@mmalina mmalina merged commit 1c3ecbb into konflux-ci:main Nov 1, 2024
3 of 4 checks passed
@wcheang wcheang mentioned this pull request Nov 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmalina mmalina mmalina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wcheang @mmalina