Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update product level SBOM name #288

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Update product level SBOM name #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sbom/create_product_sbom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ def create_sbom(data_path: str) -> Dict:
"created": datetime.now(timezone.utc).isoformat(timespec="seconds"),
"creators": ["Organization: Red Hat", "Tool: Konflux CI"],
},
"name": f"{product_name}_{product_version}",
"name": f"{product_name} {product_version}",
"packages": packages,
"relationships": relationships,
}
Expand Down
6 changes: 3 additions & 3 deletions sbom/test_create_product_sbom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def test_create_sbom_no_components(self, mock_datetime: MagicMock, mock_uuid: Ma
"created": time.isoformat(timespec="seconds"),
"creators": ["Organization: Red Hat", "Tool: Konflux CI"],
},
"name": "product_1.2.3",
"name": "product 1.2.3",
"packages": [
{
"SPDXID": "SPDXRef-product",
Expand Down Expand Up @@ -98,7 +98,7 @@ def test_create_sbom_single_component(
"created": time.isoformat(timespec="seconds"),
"creators": ["Organization: Red Hat", "Tool: Konflux CI"],
},
"name": "product_1.2.3",
"name": "product 1.2.3",
"packages": [
{
"SPDXID": "SPDXRef-product",
Expand Down Expand Up @@ -178,7 +178,7 @@ def test_create_sbom_multiple_components_multiple_purls(
"created": time.isoformat(timespec="seconds"),
"creators": ["Organization: Red Hat", "Tool: Konflux CI"],
},
"name": "product_1.2.3",
"name": "product 1.2.3",
"packages": [
{
"SPDXID": "SPDXRef-product",
Expand Down