Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RELEASE-1328): embargo-check pipeline is called via git resolver #783

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

johnbieren
Copy link
Collaborator

Describe your changes

Relevant Jira

Checklist before requesting a review

  • I have marked as draft or added do not merge label if there's a dependency PR
    • If you want reviews on your draft PR, you can add reviewers or add the release-service-maintainers handle if you are unsure who to tag
  • My commit message includes Signed-off-by: My name <email>
  • I have bumped the task/pipeline version string and updated changelog in the relevant README
  • I read CONTRIBUTING.MD and commit formatting

Copy link

openshift-ci bot commented Jan 23, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@johnbieren
Copy link
Collaborator Author

Relates to #782

@johnbieren johnbieren changed the title Release1328 feat(RELEASE-1328): embargo-check pipeline is called via git resolver Jan 23, 2025
@johnbieren johnbieren force-pushed the release1328 branch 2 times, most recently from 8ed82f8 to 4dc86a0 Compare January 24, 2025 15:31
@johnbieren johnbieren marked this pull request as ready for review January 24, 2025 15:31
@johnbieren johnbieren requested a review from a team as a code owner January 24, 2025 15:31
@johnbieren
Copy link
Collaborator Author

/retest

1 similar comment
@johnbieren
Copy link
Collaborator Author

/retest

@johnbieren johnbieren force-pushed the release1328 branch 4 times, most recently from 964cdba to 00b7981 Compare January 24, 2025 20:14
This commit updates the managed task that calls the embargo-check
internal pipeline to call the pipeline via git resolver instead of
cluster resolver. It also moves the internal embargo-check pipeline to
its proper directory, which is where the internal-request script expects
it.

Signed-off-by: Johnny Bieren <[email protected]>
@johnbieren
Copy link
Collaborator Author

/retest

@openshift-ci openshift-ci bot added the lgtm label Jan 27, 2025
@johnbieren johnbieren enabled auto-merge (squash) January 27, 2025 14:25
@johnbieren
Copy link
Collaborator Author

/retest

@johnbieren johnbieren merged commit 8376e33 into konflux-ci:development Jan 27, 2025
8 checks passed
@johnbieren johnbieren deleted the release1328 branch January 27, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants