Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose container port for probes #149

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

tkdchen
Copy link
Contributor

@tkdchen tkdchen commented Sep 29, 2024

kube-linter reports errors for this missing exposed container port.

kube-linter reports errors for this missing exposed container port.
@tkdchen
Copy link
Contributor Author

tkdchen commented Sep 29, 2024

The issue is caught in PR #147 check https://github.com/konflux-ci/image-controller/actions/runs/11069375671/job/30756800248?pr=147 and also happens from the main branch.

I'm using go1.22.7 and kube-linter@latest is used for the check in both GH action and local on my laptop.

@tkdchen
Copy link
Contributor Author

tkdchen commented Sep 29, 2024

/retest

2 similar comments
@tkdchen
Copy link
Contributor Author

tkdchen commented Sep 29, 2024

/retest

@tkdchen
Copy link
Contributor Author

tkdchen commented Sep 30, 2024

/retest

@openshift-ci openshift-ci bot added the lgtm label Sep 30, 2024
@tkdchen tkdchen merged commit 9f4b0f3 into konflux-ci:main Sep 30, 2024
11 checks passed
@tkdchen tkdchen deleted the expose-manager-pod-ports branch September 30, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants