Exclude Konflux application name from image name #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
STONEBLD-2693
|
/test image-controller-e2e |
1 similar comment
|
/test image-controller-e2e |
mmorhun
approved these changes
Sep 30, 2024
|
The reason behind this change wasn't clear to me until I've read the story. |
|
New changes are detected. LGTM label has been removed. |
|
@tnevrlka Good point. To save time from waiting the e2e-tests again, I updated the PR description this time. I also added an item for an improvement in the retro doc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STONEBLD-2693
Since Components have unique name, it's safe to remove application name from the image name.