Grant read access to additional users on image repository creation, #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcerven
changed the title
rcerven
force-pushed
the
grant_access
branch
2 times, most recently
from
855e1d4
to
2464d43
Compare
rcerven
changed the title
mmorhun
reviewed
Aug 8, 2024
There was a problem hiding this comment.
For adding users on image repository creation current implementation is fine, but in the nearest future when we need to support changing users list dynamically for all image repositories, this approach is not optimal. Better way would be to create a team per workspace with the configmap and add users dynamically to the team.
But for this PR you don't have to rework it.
based on config map in the user namespace named "image-controller-additional-users" STONEBLD-2666 Signed-off-by: Robert Cerven <[email protected]>
mmorhun
approved these changes
Aug 9, 2024
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on config map in the user namespace named "image-controller-additional-users"
STONEBLD-2666