Do not delete sig/att/sbom if subject image exists #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arewm
approved these changes
May 23, 2024
tkdchen
reviewed
May 27, 2024
|
|
||
| with self.assertRaisesRegex(AssertionError, expected_regex="no logs of level INFO"): | ||
| with self.assertLogs(LOGGER) as logs: | ||
| remove_tags(tags, QUAY_TOKEN, "some", "repository", dry_run=True) |
There was a problem hiding this comment.
It does not make sense to set dry_run=True here. When it is True, delete_image_tag will be never called under whatever conditions.
There was a problem hiding this comment.
well it was in that other test above :)
chmeliik
reviewed
May 27, 2024
|
added caching, so we will query manifest only once |
when getting all tags in registry we are listing only active tags, if tag was removed for the image, image still will be in registry if it is part of image index if manifest digest isn't present in any of active tags, try query also manifest digest to verify its presence also re-enable pruner STONEBLD-2466 Signed-off-by: Robert Cerven <[email protected]>
|
@rcerven: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
chmeliik
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when getting all tags in registry we are listing only active tags, if tag was removed for the image, image still will be in registry if it is part of image index
if manifest digest isn't present in any of active tags, try query also manifest digest to verify its presence
STONEBLD-2466