Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remote secret decomission #110

Merged
merged 15 commits into from
May 31, 2024
Merged

Remote secret decomission #110

merged 15 commits into from
May 31, 2024

Conversation

mshaposhnik
Copy link
Contributor

@mshaposhnik mshaposhnik commented May 14, 2024 •
edited by skabashnyuk
Loading

This PR:

  • Changes the newly created push and pull secrets to be plain K8S secrets instead of remote secrets
  • Add migration script for existing Remote secrets to the plain ones.
  • Remove remotesecret from project dependencies

Related to :

@mshaposhnik
Remote secret decomission
c30033e 
Signed-off-by: Max Shaposhnyk <[email protected]>
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 14, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@mshaposhnik
Add script
40a1789 
Signed-off-by: Max Shaposhnyk <[email protected]>
@mshaposhnik
Merge branch 'main' into rs_decomission
a7264e8
@mshaposhnik
Fixups
600822f 
Signed-off-by: Max Shaposhnyk <[email protected]>
@mshaposhnik
Fixups
7a069ce 
Signed-off-by: Max Shaposhnyk <[email protected]>
@mshaposhnik mshaposhnik marked this pull request as ready for review May 16, 2024 06:51
@openshift-ci openshift-ci bot requested review from mmorhun and psturc May 16, 2024 06:51
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mshaposhnik
Resolve conflicts
230bdcc 
Signed-off-by: Max Shaposhnyk <[email protected]>
@mshaposhnik
Copy link
Contributor Author

/retest

mmorhun
mmorhun reviewed May 20, 2024
View reviewed changes
controllers/imagerepository_controller.go
@@ -43,7 +42,7 @@ import (
)

const (
InternalRemoteSecretLabelName = "appstudio.redhat.com/internal"
InternalSecretLabelName = "appstudio.redhat.com/internal"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this annotation still used by UI?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about UI, but in my opinion it is useful to left any mark that secret created internally by some routine,
so user is aware it may be modified/removed without his consent

controllers/imagerepository_controller_test.go Outdated Show resolved Hide resolved
controllers/suite_util_test.go Outdated Show resolved Hide resolved
controllers/imagerepository_controller.go Outdated Show resolved Hide resolved
@mshaposhnik
Fixups
5aee388 
Signed-off-by: Max Shaposhnyk <[email protected]>
@mshaposhnik
Copy link
Contributor Author

/retest

@skabashnyuk
Copy link

looks good to me

@mshaposhnik
Fixups
4d8d165 
Signed-off-by: Max Shaposhnyk <[email protected]>
mmorhun
mmorhun approved these changes May 30, 2024
View reviewed changes
controllers/imagerepository_controller.go Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added the lgtm label May 30, 2024
@mshaposhnik
Fixups
b01e6d5 
Signed-off-by: Max Shaposhnyk <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label May 30, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 30, 2024

New changes are detected. LGTM label has been removed.

@konflux-ci konflux-ci deleted a comment from openshift-ci bot May 31, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 31, 2024

@mmorhun: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test image-controller-e2e
  • /test images

Use /test all to run all jobs.

In response to this:

/test image-controller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mmorhun mmorhun merged commit 83b8a0a into konflux-ci:main May 31, 2024
9 of 11 checks passed
@rh-tap-build-team rh-tap-build-team bot mentioned this pull request Jun 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmorhun mmorhun mmorhun approved these changes

@psturc psturc Awaiting requested review from psturc

Assignees

@mmorhun mmorhun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mshaposhnik @skabashnyuk @mmorhun