Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to migration bundles #1861

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tkdchen
Copy link
Contributor

@tkdchen tkdchen commented Jan 27, 2025

Any task bundles that have migrations are linked by the newer task bundles by a dedicated annotation. See the following example task bundles:

  tb0 -->  tb1 --> tb2 --> tb3 --> tb4 --> tb5
           |               |
           M               M

where, tb2 and tb3 point to tb1, and tb4 and tb5 point to tb3.

Linking task bundles helps to reduce the number of HTTP requests made to Quay.io that query which task bundles have migrations.

Terms:

  • tb means task bundle.
  • M means migration.

@tkdchen tkdchen requested a review from a team as a code owner January 27, 2025 05:50
@tkdchen tkdchen force-pushed the link-migration-bundles branch from 667dc90 to 110af20 Compare January 27, 2025 06:04
Copy link
Contributor

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea!

local -r task_version=${2:?Missing task version}
local -r repo=${TEST_REPO_NAME:-task-${task_name}}

local -r url_list_recent_tags="https://quay.io/api/v1/repository/${QUAY_NAMESPACE}/${repo}/tag/?onlyActiveTags=true&limit=30"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific reason for limit=30? Shall we just use Quay's maximum, i.e. limit=100?

Copy link
Contributor Author

@tkdchen tkdchen Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the link, the first tag is enough to build the link. I selected 30 for my testing by using a single test image repo. Updated it to 100 so that it can cover more cases for convenience.

@tkdchen tkdchen force-pushed the link-migration-bundles branch from 110af20 to a72139f Compare January 27, 2025 09:15
Any task bundles that have migrations are linked by the newer task
bundles by a dedicated annotation. See the following example task
bundles:

  tb0 -->  tb1 --> tb2 --> tb3 --> tb4 --> tb5
           |               |
           M               M

where, tb2 and tb3 point to tb1, and tb4 and tb5 point to tb3.

Linking task bundles helps to reduce the number of HTTP requests made to
Quay.io that query which task bundles have migrations.

Terms:

- tb means task bundle.
- M means migration.
@tkdchen tkdchen force-pushed the link-migration-bundles branch from a72139f to bc49d05 Compare January 27, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants