-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link to migration bundles #1861
base: main
Are you sure you want to change the base?
Conversation
667dc90
to
110af20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea!
hack/build-and-push.sh
Outdated
local -r task_version=${2:?Missing task version} | ||
local -r repo=${TEST_REPO_NAME:-task-${task_name}} | ||
|
||
local -r url_list_recent_tags="https://quay.io/api/v1/repository/${QUAY_NAMESPACE}/${repo}/tag/?onlyActiveTags=true&limit=30" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a specific reason for limit=30
? Shall we just use Quay's maximum, i.e. limit=100
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the link, the first tag is enough to build the link. I selected 30 for my testing by using a single test image repo. Updated it to 100 so that it can cover more cases for convenience.
110af20
to
a72139f
Compare
Any task bundles that have migrations are linked by the newer task bundles by a dedicated annotation. See the following example task bundles: tb0 --> tb1 --> tb2 --> tb3 --> tb4 --> tb5 | | M M where, tb2 and tb3 point to tb1, and tb4 and tb5 point to tb3. Linking task bundles helps to reduce the number of HTTP requests made to Quay.io that query which task bundles have migrations. Terms: - tb means task bundle. - M means migration.
a72139f
to
bc49d05
Compare
Any task bundles that have migrations are linked by the newer task bundles by a dedicated annotation. See the following example task bundles:
where, tb2 and tb3 point to tb1, and tb4 and tb5 point to tb3.
Linking task bundles helps to reduce the number of HTTP requests made to Quay.io that query which task bundles have migrations.
Terms: