SAST tests: Creation of tests for SAST tasks #1843
Conversation
jperezdealgaba
force-pushed
the
sast-tests
branch
4 times, most recently
from
d895de6 to
b472131
Compare
|
@kdudka Would you mind giving a preliminary review? There are a few discussions needed here |
| workspace: tests-workspace | ||
| params: | ||
| - name: url | ||
| value: https://github.com/jperezdealgaba/test_unicode_control |
There was a problem hiding this comment.
@kdudka This is the repo that was used to test the original task (https://gitlab.cee.redhat.com/chhan/unicode_control_test). I moved it to GitHub as the tests couldn't resolve to the internal GitLab.
This is in my personal organization, I really think this should be moved to a more "professional" org if not choosing a different repository.
There was a problem hiding this comment.
@ralphbean Could we include the test data into https://github.com/konflux-ci/testrepo or another project in the konflux-ci GitHub namespace so that the tests do not depend on 3rd party repositories?
|
/ok-to-test |
| value: task/init/0.2/init.yaml | ||
| params: | ||
| - name: image-url | ||
| value: "quay.io/redhat-user-workloads/jperezde-tenant/tests/tests-sast-unicode-check:latest" |
There was a problem hiding this comment.
Another aspect to discuss is the fact that this repo doesn't exist. So the upload is never done. I understand that the upload process is outside of the scope of the function.
Do we want to upload the results?
There was a problem hiding this comment.
If we have a meaningful image-url that could be used for testing, it would increase the test coverage. If not, we can modify the task to skip the upload in case an empty string is provided as image-url, which is how the sast-snyk-check task worked initially.
jperezdealgaba
force-pushed
the
sast-tests
branch
from
b472131 to
4eedf98
Compare
jperezdealgaba
force-pushed
the
sast-tests
branch
from
4a493cc to
6c36913
Compare
Before you complete this pull request ...
Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.