Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OCI/TA variant of the tkn-bundle Task #1596

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Add OCI/TA variant of the tkn-bundle Task #1596

merged 1 commit into from
Nov 15, 2024
+207 −8

Conversation

zregvart
Copy link
Member

@zregvart zregvart force-pushed the issue/EC-979 branch 2 times, most recently from 9c4073f to 3bc6763 Compare November 12, 2024 12:32
lcarva
lcarva reviewed Nov 12, 2024
View reviewed changes
task/tkn-bundle-oci-ta/0.1/recipe.yaml
- source
preferStepTemplate: true
replacements:
workspaces.source.path: /var/workdir/source
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be /var/workdir?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, the restored source is in /var/workdir/source, then the Task reads from there (example)

lcarva
lcarva approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@lcarva lcarva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@zregvart zregvart added this pull request to the merge queue Nov 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 14, 2024
@zregvart zregvart added this pull request to the merge queue Nov 15, 2024
Merged via the queue into konflux-ci:main with commit 48c311a Nov 15, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcarva lcarva lcarva approved these changes

@brunoapimentel brunoapimentel Awaiting requested review from brunoapimentel

@simonbaird simonbaird Awaiting requested review from simonbaird

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zregvart @lcarva