Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve #29 - Refactor PTO today Use Case #36

Merged
merged 14 commits into from
May 7, 2024
Merged

Solve #29 - Refactor PTO today Use Case #36

merged 14 commits into from
May 7, 2024

Conversation

FelipeGuzmanSierra
Copy link
Collaborator

@FelipeGuzmanSierra FelipeGuzmanSierra commented May 3, 2024 •
edited
Loading

Solve #29

Description

On this PR, the new structure of the project was added, and three BOT's were defined. These are:

  • Bot to fetch pto's from a Notion database.
  • Bot to format today's ptos notification message using an OpenAI assistant to humanize the message.
  • Bot to send notification messages to a Discord server.

@FelipeGuzmanSierra FelipeGuzmanSierra added the 👍 Feature New feature or request label May 3, 2024
@coveralls
Copy link

coveralls commented May 6, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8976421404

Details

  • 663 of 663 (100.0%) changed or added relevant lines in 56 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 8760390293: 0.0%
Covered Lines: 1317
Relevant Lines: 1317
💛 - Coveralls

@FelipeGuzmanSierra FelipeGuzmanSierra marked this pull request as ready for review May 6, 2024 12:30
L-Zuluaga
L-Zuluaga requested changes May 6, 2024
View reviewed changes
Copy link
Member

@L-Zuluaga L-Zuluaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some questions and pointed some typo errors I found!

Excellent work! 🚀

lib/v2/bot/base.rb Outdated Show resolved Hide resolved
lib/bas/domain/exceptions/function_not_implement.rb Show resolved Hide resolved
lib/v2/utils/openai/run_assistant.rb Outdated Show resolved Hide resolved
spec/v2/write/postgres_spec.rb Outdated Show resolved Hide resolved
@FelipeGuzmanSierra FelipeGuzmanSierra merged commit ab0ec4c into main May 7, 2024
4 checks passed
@FelipeGuzmanSierra FelipeGuzmanSierra deleted the refactor-pto-today branch May 7, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L-Zuluaga L-Zuluaga L-Zuluaga approved these changes

Assignees

@miguelnietoa miguelnietoa

@FelipeGuzmanSierra FelipeGuzmanSierra

Labels
👍 Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FelipeGuzmanSierra @coveralls @L-Zuluaga @miguelnietoa