Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve #15 - Rename the Dispatcher to Process #19

Merged
merged 5 commits into from
Apr 15, 2024
Merged

Solve #15 - Rename the Dispatcher to Process #19

merged 5 commits into from
Apr 15, 2024

Conversation

FelipeGuzmanSierra
Copy link
Collaborator

Closes #15

Description

In this PR, the Dispatcher component was renamed to Process. For this:

  • The component was updated
  • The use cases were updated
  • The Documentation was updated
  • The tests were updated

@FelipeGuzmanSierra FelipeGuzmanSierra self-assigned this Apr 12, 2024
@FelipeGuzmanSierra FelipeGuzmanSierra added the 👍 Feature New feature or request label Apr 12, 2024
@coveralls
Copy link

coveralls commented Apr 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8691197792

Details

  • 71 of 71 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 8668116408: 0.0%
Covered Lines: 581
Relevant Lines: 581
💛 - Coveralls

@FelipeGuzmanSierra FelipeGuzmanSierra marked this pull request as ready for review April 12, 2024 21:34
L-Zuluaga
L-Zuluaga requested changes Apr 15, 2024
View reviewed changes
Copy link
Member

@L-Zuluaga L-Zuluaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just left a small doubts with some typos 👍🏻

README.md Outdated Show resolved Hide resolved
lib/bas/formatter/birthday.rb Outdated Show resolved Hide resolved
@FelipeGuzmanSierra FelipeGuzmanSierra merged commit bc15acd into main Apr 15, 2024
4 checks passed
@FelipeGuzmanSierra FelipeGuzmanSierra deleted the 15-rename-dispatcher-to-process branch April 15, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L-Zuluaga L-Zuluaga L-Zuluaga approved these changes

Assignees

@FelipeGuzmanSierra FelipeGuzmanSierra

Labels
👍 Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename the Dispatcher to Process
3 participants
@FelipeGuzmanSierra @coveralls @L-Zuluaga