Improve web availability bot notification message (#100)

kommitters · Sep 6, 2024 · 2817a1d · 2817a1d
1 parent 37f49b7
commit 2817a1d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 10 deletions.
diff --git a/lib/bas/bot/fetch_billing_from_digital_ocean.rb b/lib/bas/bot/fetch_billing_from_digital_ocean.rb
@@ -81,9 +81,7 @@ def params
     end
 
     def last_billing
-      return read_response.data["billing"] unless read_response.data.nil?
-
-      { month_to_date_balance: 0 }
+      read_response.data.nil? ? nil : read_response.data["billing"]
     end
   end
 end
diff --git a/lib/bas/bot/review_domain_availability.rb b/lib/bas/bot/review_domain_availability.rb
@@ -90,12 +90,7 @@ def availability
     end
 
     def notification(response)
-      data = {
-        domain: read_response.data["url"],
-        status_code: response.code
-      }
-
-      ":warning: Domain is down: #{data}"
+      ":warning: The Domain #{read_response.data["url"]} is down with an error code of #{response.code}"
     end
   end
 end
diff --git a/spec/bas/bot/fetch_billing_from_digital_ocean_spec.rb b/spec/bas/bot/fetch_billing_from_digital_ocean_spec.rb
@@ -110,7 +110,7 @@
 
       processed = @bot.process
 
-      expect(processed).to eq({ success: { billing: do_bill, last_billing: { month_to_date_balance: 0 } } })
+      expect(processed).to eq({ success: { billing: do_bill, last_billing: nil } })
     end
 
     it "returns a success hash with the digital ocean bill when a last billing was not found" do