Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more dpmsolver++2m samplers to solve SDXL sampling artifacts #1895

Draft
wants to merge 2 commits into
base: sd3
Choose a base branch
from

Conversation

rockerBOO
Copy link
Contributor

Visual artifacting for sampling using dpmsolver++. This adds more samplers but dpmsolver++_2m_lu should produce better results on SDXL.

sample_2_880_1c033a0dba24b098ea6d

huggingface/diffusers#5433
huggingface/diffusers#5541

@rockerBOO
Copy link
Contributor Author

I thought I did this correctly as referred to in the linked issues, but there are a few things I need to figure out. I can't easily test this outside of training so will take some time to fiddle with it. The schedulers are having a set value being passed but not sure why. I looked back in the history but did not find any indication of why, except it is using the defaults from one of the schedulers.

    scheduler = scheduler_cls(
        num_train_timesteps=SCHEDULER_TIMESTEPS,
        beta_start=SCHEDULER_LINEAR_START,
        beta_end=SCHEDULER_LINEAR_END,
        beta_schedule=SCHEDLER_SCHEDULE,
       ...

So I am trying some experiments with it removed but it will cause samples to be different than before with the same settings, which can make it difficult to compare. At least find something that works better for SDXL sampling and then we can work back from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant