Make sure "finalize" methods suppress all warnings, don't @OverRide

In preparation of a future deprecation-for-removal of the finalize methods, make sure we don't declare @OverRide on it. Suppress all warnings on the method that may arise from the presently missing @OverRide statement, and the variety of code checkers (checkstyle, PMD, errorpone, etc.)
kohlschutter · Nov 10, 2023 · 699e665 · 699e665
1 parent 8a9a91d
commit 699e665
Show file tree

Hide file tree

Showing 8 changed files with 8 additions and 17 deletions.
diff --git a/junixsocket-common/src/main/java8/org/newsclub/net/unix/CleanableState.java b/junixsocket-common/src/main/java8/org/newsclub/net/unix/CleanableState.java
@@ -34,8 +34,7 @@ public final void runCleaner() {
     }
   }
 
-  @SuppressWarnings({"all", "Finalize" /* errorprone */})
-  @Override
+  @SuppressWarnings("all")
   @Deprecated
   protected final void finalize() {
     try {

diff --git a/junixsocket-common/src/main/java8/org/newsclub/net/unix/DatagramSocketImplShim.java b/junixsocket-common/src/main/java8/org/newsclub/net/unix/DatagramSocketImplShim.java
@@ -30,7 +30,6 @@ protected DatagramSocketImplShim() {
   }
 
   @SuppressWarnings("all")
-  @Override
   @Deprecated
   protected final void finalize() {
     try {

diff --git a/junixsocket-common/src/main/java8/org/newsclub/net/unix/SocketImplShim.java b/junixsocket-common/src/main/java8/org/newsclub/net/unix/SocketImplShim.java
@@ -33,8 +33,7 @@ protected SocketImplShim() {
     super();
   }
 
-  @SuppressWarnings({"all", "Finalize" /* errorprone */})
-  @Override
+  @SuppressWarnings("all")
   @Deprecated
   protected final void finalize() {
     try {

diff --git a/junixsocket-common/src/test/java/org/newsclub/net/unix/SocketTestBase.java b/junixsocket-common/src/test/java/org/newsclub/net/unix/SocketTestBase.java
@@ -86,9 +86,8 @@ protected SocketTestBase(AddressSpecifics<A> asp) {
     }
   }
 
-  @SuppressWarnings({"NoFinalizer" /* checkstyle */, "PMD.EmptyFinalizer"})
+  @SuppressWarnings("all")
   @Deprecated
-  @Override
   protected final void finalize() {
   }
 
@@ -182,9 +181,8 @@ protected ServerThread() throws IOException, InterruptedException {
       readySema.acquire();
     }
 
-    @SuppressWarnings({"NoFinalizer" /* checkstyle */, "PMD.EmptyFinalizer"})
+    @SuppressWarnings("all")
     @Deprecated
-    @Override
     protected final void finalize() {
     }
 

diff --git a/junixsocket-rmi/src/test/java/org/newsclub/net/unix/rmi/RemoteCloseableThingImpl.java b/junixsocket-rmi/src/test/java/org/newsclub/net/unix/rmi/RemoteCloseableThingImpl.java
@@ -34,9 +34,8 @@ abstract class RemoteCloseableThingImpl implements RemoteCloseableThing {
   protected RemoteCloseableThingImpl() throws RemoteException {
   }
 
-  @SuppressWarnings({"NoFinalizer" /* checkstyle */, "PMD.EmptyFinalizer"})
+  @SuppressWarnings("all")
   @Deprecated
-  @Override
   protected final void finalize() {
   }
 

diff --git a/junixsocket-rmi/src/test/java/org/newsclub/net/unix/rmi/RemoteRegistryTest.java b/junixsocket-rmi/src/test/java/org/newsclub/net/unix/rmi/RemoteRegistryTest.java
@@ -220,9 +220,8 @@ private static class SpawnedRegistryAccess implements AutoCloseable {
       asyncGetRegistry();
     }
 
-    @SuppressWarnings({"NoFinalizer" /* checkstyle */, "PMD.EmptyFinalizer"})
+    @SuppressWarnings("all")
     @Deprecated
-    @Override
     protected final void finalize() {
     }
 

diff --git a/junixsocket-rmi/src/test/java/org/newsclub/net/unix/rmi/TestBase.java b/junixsocket-rmi/src/test/java/org/newsclub/net/unix/rmi/TestBase.java
@@ -42,9 +42,8 @@ protected AFNaming newNamingTestInstance() throws IOException {
     return AFUNIXNaming.newPrivateInstance();
   }
 
-  @SuppressWarnings({"NoFinalizer" /* checkstyle */, "PMD.EmptyFinalizer"})
+  @SuppressWarnings("all")
   @Deprecated
-  @Override
   protected final void finalize() {
   }
 

diff --git a/junixsocket-tipc/src/main/java/org/newsclub/net/unix/tipc/AFTIPCTopologyWatcher.java b/junixsocket-tipc/src/main/java/org/newsclub/net/unix/tipc/AFTIPCTopologyWatcher.java
@@ -68,9 +68,8 @@ public AFTIPCTopologyWatcher(int defaultTimeoutSeconds) throws IOException {
     channel.configureBlocking(false);
   }
 
-  @SuppressWarnings({"NoFinalizer" /* checkstyle */, "PMD.EmptyFinalizer"})
+  @SuppressWarnings("all")
   @Deprecated
-  @Override
   protected final void finalize() {
   }