Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ansible Makefile doesnt seem to like being in a directory with spaces in the filename #158

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

MoralCode
Copy link

when trying to bring up knix with one host (a VM) I got stuck with the following error (actual file path redacted):

$ make
cd ../../riak && make lib/jiffy.tgz && cd -
make[1]: Entering directory '/path/to/Some Directory/that/Contains A Few/spaces/riak'
mkdir -p lib
echo "Building jiffy"
Building jiffy
Container image riak_libs_build:0.9.0-29-g4c8f006-dirty is already up-to-date
docker run -i --rm -u $(id -u):$(id -g) -v /path/to/Some Directory/that/Contains A Few/spaces/riak:/temp -w /temp --ulimit nofile=262144:262144 riak_libs_build:0.9.0-29-g4c8f006-dirty cp /build/jiffy.tgz ./lib/.
docker: invalid reference format: repository name must be lowercase.
See 'docker run --help'.
make[1]: *** [Makefile:27: lib/jiffy.tgz] Error 125
make[1]: Leaving directory '/path/to/Some Directory/that/Contains A Few/spaces/riak'
make: *** [Makefile:50: ../../riak/knix_riak_deployment_package.tar.gz] Error 2

I was able to locate the spot where i could enclose the path path (-v /path/to/Some Directory/that/Contains A Few/spaces/riak:/temp) in quotes to allow it to handle file paths containing spaces

@iakkus
Copy link
Member

iakkus commented Apr 23, 2024

Thanks for the PR. I am not sure this is a critical requirement; it's more like a personal style to have spaces in directory names (and in many UNIX variants, usually against the general convention).

We'll let the PR stay in case anyone needs it.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants