-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump github.com/gorilla/websocket from 1.4.2 to 1.5.0 #2775
Bump github.com/gorilla/websocket from 1.4.2 to 1.5.0 #2775
Conversation
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2775 +/- ##
=======================================
Coverage 81.82% 81.82%
=======================================
Files 167 167
Lines 10201 10201
=======================================
Hits 8347 8347
Misses 1608 1608
Partials 246 246 ☔ View full report in Codecov by Sentry. |
@dependabot rebase |
09931f6
to
1fba26e
Compare
/ok-to-test |
/easycla |
@dependabot recreate |
Bumps [github.com/gorilla/websocket](https://github.com/gorilla/websocket) from 1.4.2 to 1.5.0. - [Release notes](https://github.com/gorilla/websocket/releases) - [Commits](gorilla/websocket@v1.4.2...v1.5.0) --- updated-dependencies: - dependency-name: github.com/gorilla/websocket dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
c4599d4
to
1f7104c
Compare
Closing & re-opening the PR triggered the github action #2774 |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
@kvmware can you open a GitHub support issue for https://github.com/orgs/community/discussions/62346 ? |
Created a ticket but it seems to be a personal ticket. Even though I opened it in name of knative |
/retest |
It looks like the github action was ran https://github.com/knative/pkg/actions/runs/5721737661 but it was skipped. |
The failure was from a flakey unit test which has passed with retest. This PR just needs LGTM and approval |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dependabot[bot], kvmware The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Bumps github.com/gorilla/websocket from 1.4.2 to 1.5.0.
Release notes
Sourced from github.com/gorilla/websocket's releases.
Commits
9111bb8
Dialer: add optional method NetDialTLSContext (#746)2f25f78
Update README (#757)4fad403
Remove support for Go 1.8f0643a3
Improve protocol error messages2d6ee4c
Update autobahn examplebeca1d3
Fix broadcast benchmarks (#542)bcef843
Use context.Context in TLS handshake (#751)2c89656
Modify http Method String Literal to Variable (#728)1905f7e
Update source to match output from gofmt 1.17b4b5d88
Document the allowed concurrency on Upgrader and Dialer (#636)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)