prioritize destination CA certs over resolved addressable CA certs (#…

…2849) Signed-off-by: pingjiang <[email protected]>
knative · Oct 3, 2023 · 833dd97 · 833dd97
1 parent 294e777
commit 833dd97
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/resolver/addressable_resolver.go b/resolver/addressable_resolver.go
@@ -257,7 +257,7 @@ func (r *URIResolver) addressableFromDestinationRef(ctx context.Context, dest du
 		return nil, apierrs.NewBadRequest(fmt.Sprintf("hostname missing in address of %s", dest.Ref))
 	}
 
-	if addr.CACerts == nil {
+	if dest.CACerts != nil && *dest.CACerts != "" {
 		addr.CACerts = dest.CACerts
 	}
 

diff --git a/resolver/addressable_resolver_test.go b/resolver/addressable_resolver_test.go
@@ -848,7 +848,7 @@ func TestAddressableFromDestinationV1CACerts(t *testing.T) {
 			addressableWithCACert(),
 		},
 		addr:     addressableWithCACert(),
-		wantCert: CACert,
+		wantCert: certDestination,
 	}}
 
 	for n, tc := range tests {