-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shell executor logs through testing.T in upgrade tests #1598
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mgencur The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mgencur: 0 warnings.
In response to this:
Similar to knative/serving#14495
Fixes #
Proposed Changes
- Print logs from shell executor to testing.T so that the logs can be found within test scope
Release Note
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mgencur can you rebase? |
This Pull Request is stale because it has been open for 90 days with |
Let me ping @mgencur one more time to see if he can rebase and fix the CI issues with this PR. |
Similar to knative/serving#14495
Fixes #
Proposed Changes
Release Note