Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.15] Release 1.15.1 #2480

Merged
merged 7 commits into from
Sep 5, 2024

Conversation

matejvasek
Copy link
Contributor

Changes

jrangelramos and others added 7 commits July 25, 2024 06:53
* Remove superfluous equals sign from envvar

Signed-off-by: Matej Vašek <[email protected]>

* Update rust templates Cargo.lock

Signed-off-by: Matej Vašek <[email protected]>

---------

Signed-off-by: Matej Vašek <[email protected]>
* init fix

Signed-off-by: gauron99 <[email protected]>

* dont override direct deploy tag, more tests

Signed-off-by: gauron99 <[email protected]>

* fix

Signed-off-by: gauron99 <[email protected]>

* dont validate with tagged image, fix comment

Signed-off-by: gauron99 <[email protected]>

* init run fix for --image

Signed-off-by: gauron99 <[email protected]>

* init

Signed-off-by: gauron99 <[email protected]>

* int test, add valid untdigested images to run

Signed-off-by: gauron99 <[email protected]>

* check images passed to runner for func run command

Signed-off-by: gauron99 <[email protected]>

* fix build/deploy image passing bug add test

Signed-off-by: gauron99 <[email protected]>

* fix

Signed-off-by: gauron99 <[email protected]>

* remove extra printing

Signed-off-by: gauron99 <[email protected]>

* merge functions to digested

Signed-off-by: gauron99 <[email protected]>

* misspell

Signed-off-by: gauron99 <[email protected]>

* simplify

Signed-off-by: David Fridrich <[email protected]>

* quick fix

Signed-off-by: David Fridrich <[email protected]>

* remove prints, comment

Signed-off-by: David Fridrich <[email protected]>

---------

Signed-off-by: gauron99 <[email protected]>
Signed-off-by: David Fridrich <[email protected]>
* Prepare util image to accomodate multiple cmds

As of now func-util image has only one command of our own -- "deploy".
This commits prepares grounds for one additional command named "scaffolding".
The commands will be implemented in one binary and dispatched over
argv[0] using symlinks. Kinda like busybox does.

Signed-off-by: Matej Vašek <[email protected]>

* Add scaffolding for on-cluster build

Added new build step in tekton pipeline that scaffolds main() for Go
porject when using s2i builder.

Signed-off-by: Matej Vašek <[email protected]>

* Better docker build caching

This will cache dependencies between docker builds.

Signed-off-by: Matej Vašek <[email protected]>

* fixup: perms

Signed-off-by: Matej Vašek <[email protected]>

* fixup: remove broken check

Signed-off-by: Matej Vašek <[email protected]>

* fixup: remove test because of 'no space left on device'

Signed-off-by: Matej Vašek <[email protected]>

* Make func-util rootfull

Signed-off-by: Matej Vašek <[email protected]>

---------

Signed-off-by: Matej Vašek <[email protected]>
Co-authored-by: Knative Automation <[email protected]>
Signed-off-by: Matej Vašek <[email protected]>
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 4, 2024
@matejvasek matejvasek requested review from matzew, jrangelramos, gauron99 and lkingland and removed request for maximilien September 4, 2024 15:36
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 78.40909% with 19 lines in your changes missing coverage. Please review.

Project coverage is 67.12%. Comparing base (a511cd9) to head (fc3d824).
Report is 1 commits behind head on release-1.15.

Files with missing lines Patch % Lines
cmd/deploy.go 71.87% 5 Missing and 4 partials ⚠️
cmd/run.go 78.94% 2 Missing and 2 partials ⚠️
pkg/functions/client.go 33.33% 2 Missing and 2 partials ⚠️
cmd/build.go 0.00% 0 Missing and 1 partial ⚠️
pkg/pipelines/tekton/tasks.go 96.42% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.15    #2480      +/-   ##
================================================
+ Coverage         58.65%   67.12%   +8.47%     
================================================
  Files               130      129       -1     
  Lines             15354    11928    -3426     
================================================
- Hits               9006     8007     -999     
+ Misses             5450     2960    -2490     
- Partials            898      961      +63     
Flag Coverage Δ
e2e-test 36.65% <15.90%> (?)
e2e-test-oncluster 33.44% <44.31%> (+0.03%) ⬆️
e2e-test-oncluster-runtime 29.50% <35.22%> (?)
e2e-test-runtime-go 26.61% <12.50%> (?)
e2e-test-runtime-node 26.00% <12.50%> (?)
e2e-test-runtime-python 26.00% <12.50%> (?)
e2e-test-runtime-quarkus 26.10% <12.50%> (?)
e2e-test-runtime-rust 25.15% <12.50%> (?)
e2e-test-runtime-springboot 25.18% <12.50%> (?)
e2e-test-runtime-typescript 26.09% <12.50%> (?)
integration-tests 53.09% <78.40%> (+2.69%) ⬆️
unit-tests 51.30% <77.27%> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek
Copy link
Contributor Author

How much do we need - ba7d564 allow digested images to be 'run' (#2445) ?

@matejvasek matejvasek changed the title Release 1.15.1 [release-1.15.] Release 1.15.1 Sep 4, 2024
@matejvasek matejvasek changed the title [release-1.15.] Release 1.15.1 [release-1.15] Release 1.15.1 Sep 4, 2024
@dsimansk
Copy link
Contributor

dsimansk commented Sep 5, 2024

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2024
Copy link

knative-prow bot commented Sep 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dsimansk,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 858a0e8 into knative:release-1.15 Sep 5, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants