-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate client-pkg to client/pkg #2477
Conversation
c2a4cc4
to
33eeb50
Compare
Signed-off-by: David Fridrich <[email protected]>
33eeb50
to
33db18a
Compare
Signed-off-by: David Fridrich <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2477 +/- ##
==========================================
+ Coverage 61.54% 67.08% +5.53%
==========================================
Files 129 129
Lines 15334 11928 -3406
==========================================
- Hits 9438 8002 -1436
+ Misses 4970 2964 -2006
- Partials 926 962 +36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
just a nit: I would not group |
Do you want to group it with github & k8s or should i put it separately? |
Yes group it with github. I think that right now we do following grouping:
|
Signed-off-by: David Fridrich <[email protected]>
Looks good to me, but let maintainers approve. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.