Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST ONLY] #2467

Closed
wants to merge 8 commits into from
Closed

[TEST ONLY] #2467

wants to merge 8 commits into from

Conversation

matejvasek
Copy link
Contributor

Changes

/kind

Fixes #

Release Note

Docs

@matejvasek
Prepare util image to accomodate multiple cmds
d5fec1f 
As of now func-util image has only one command of our own -- "deploy".
This commits prepares grounds for one additional command named "scaffolding".
The commands will be implemented in one binary and dispatched over
argv[0] using symlinks. Kinda like busybox does.

Signed-off-by: Matej Vašek <[email protected]>
@matejvasek
Add scaffolding for on-cluster build
91fd4c1 
Added new build step in tekton pipeline that scaffolds main() for Go
porject when using s2i builder.

Signed-off-by: Matej Vašek <[email protected]>
@matejvasek
Better docker build caching
e892963 
This will cache dependencies between docker builds.

Signed-off-by: Matej Vašek <[email protected]>
@matejvasek
[DO NOT MERGE] [TEST ONLY]
1ca09cb 
Signed-off-by: Matej Vašek <[email protected]>
@knative-prow Knative Prow
Copy link

knative-prow bot commented Aug 26, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow Knative Prow
Copy link

knative-prow bot commented Aug 26, 2024

@matejvasek: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 26, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Aug 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2024
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 26, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 45.76271% with 32 lines in your changes missing coverage. Please review.

Project coverage is 66.18%. Comparing base (4775ad9) to head (7a62f03).
Report is 1 commits behind head on main.

Files Patch % Lines
cmd/func-util/main.go 0.00% 31 Missing ⚠️
pkg/pipelines/tekton/tasks.go 96.15% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2467      +/-   ##
==========================================
+ Coverage   61.22%   66.18%   +4.96%     
==========================================
  Files         130      130              
  Lines       15354    11995    -3359     
==========================================
- Hits         9400     7939    -1461     
+ Misses       5029     3095    -1934     
- Partials      925      961      +36
Flag Coverage Δ
e2e-test 36.70% <0.00%> (-0.07%) ⬇️
e2e-test-oncluster ?
e2e-test-runtime-go 26.71% <0.00%> (?)
e2e-test-runtime-node 26.09% <0.00%> (?)
e2e-test-runtime-python 26.09% <0.00%> (?)
e2e-test-runtime-quarkus 26.19% <0.00%> (?)
e2e-test-runtime-rust 25.21% <0.00%> (?)
e2e-test-runtime-springboot 25.27% <0.00%> (?)
e2e-test-runtime-typescript 26.18% <0.00%> (?)
integration-tests 52.77% <45.76%> (+2.36%) ⬆️
unit-tests 50.92% <44.06%> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek
[WIP]
901bcf2 
Signed-off-by: Matej Vašek <[email protected]>
@matejvasek
[WIP]
7552dad 
Signed-off-by: Matej Vašek <[email protected]>
@matejvasek
[WIP]
3d04ff7 
Signed-off-by: Matej Vašek <[email protected]>
@matejvasek
[WIP]
7a62f03 
Signed-off-by: Matej Vašek <[email protected]>
@matejvasek matejvasek closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrangelramos jrangelramos Awaiting requested review from jrangelramos

@vyasgun vyasgun Awaiting requested review from vyasgun

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matejvasek