-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace container to due errors #2359
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Matthias Wessendorf <[email protected]>
@matzew: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2359 +/- ##
==========================================
+ Coverage 58.34% 65.71% +7.36%
==========================================
Files 128 128
Lines 14895 11534 -3361
==========================================
- Hits 8690 7579 -1111
+ Misses 5304 2999 -2305
- Partials 901 956 +55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I think it might be better to just check if the container already exist and if it does then skip creation. |
ping @matzew |
This Pull Request is stale because it has been open for 90 days with |
Changes
Fixes #2358
/kind
Fixes #
Release Note
Docs