Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typos #1936

Merged
merged 1 commit into from
Aug 17, 2023
Merged

typos #1936

merged 1 commit into from
Aug 17, 2023

Conversation

gauron99
Copy link
Contributor

just found some typos while reading through

Signed-off-by: gauron99 <[email protected]>
@knative-prow knative-prow bot requested review from dsimansk and nainaz August 17, 2023 13:35
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 17, 2023
@gauron99
Copy link
Contributor Author

cc @matejvasek

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -1.80% ⚠️

Comparison is base (e4a3b3a) 61.82% compared to head (2ad6260) 60.02%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1936      +/-   ##
==========================================
- Coverage   61.82%   60.02%   -1.80%     
==========================================
  Files         106      106              
  Lines       13657    13657              
==========================================
- Hits         8443     8198     -245     
- Misses       4369     4617     +248     
+ Partials      845      842       -3     
Flag Coverage Δ
e2e-test ?
e2e-test-oncluster 30.51% <100.00%> (+0.08%) ⬆️
e2e-test-oncluster-runtime 25.29% <100.00%> (?)
integration-tests 51.49% <100.00%> (+2.15%) ⬆️
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest 48.28% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cmd/build.go 67.64% <100.00%> (ø)
cmd/deploy.go 73.53% <100.00%> (ø)

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek
Copy link
Contributor

/approve
/lgmt

@knative-prow
Copy link

knative-prow bot commented Aug 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2023
@matejvasek
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2023
@knative-prow knative-prow bot merged commit 5135a92 into knative:main Aug 17, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants