feat: tekton task urls in the environment sub-command output
#1925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matej Vasek <[email protected]>
knative-prow
bot
added
approved
matejvasek
requested review from
lkingland,
jrangelramos,
gauron99 and
salaboy
and removed request for
rhuss and
navidshaikh
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1925 +/- ##
==========================================
+ Coverage 61.85% 62.75% +0.90%
==========================================
Files 107 107
Lines 13813 13817 +4
==========================================
+ Hits 8544 8671 +127
+ Misses 4415 4267 -148
- Partials 854 879 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
PTAL @jrangelramos @gauron99 |
|
/retest-required |
Shashankft9
approved these changes
Aug 13, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matejvasek, Shashankft9 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
matejvasek
added a commit
to matejvasek/faas
that referenced
this pull request
Sep 27, 2023
Signed-off-by: Matej Vasek <[email protected]>
matejvasek
added a commit
to matejvasek/faas
that referenced
this pull request
Sep 27, 2023
Signed-off-by: Matej Vasek <[email protected]>
knative-prow bot
pushed a commit
that referenced
this pull request
Oct 2, 2023
* chore: use tkn tasks from PR branch in CI (#1914) Signed-off-by: Matej Vasek <[email protected]> * chore: released binaries refer correct task yamls (#1916) Signed-off-by: Matej Vasek <[email protected]> * chore: refer correct tkn yaml in prow test (#1918) Without this change prow test will refer tkn yamls from the main branch not from the PR head branch. Signed-off-by: Matej Vasek <[email protected]> * chore: update release generation (#1924) * Minimize release binary size. * Release latest version of buildpack tekton task. Signed-off-by: Matej Vasek <[email protected]> * test: update github ref used on e2e oncluster tests (#1917) * test: Split of GH oncluster tests by builder. Added FUNC_BUILDER env var for e2e oncluter tests (#1963) * Use our own s2i image (#1971) Our image is much more recent and it is multiarch. Signed-off-by: Matej Vasek <[email protected]> * chore: update buildah image ref (#1960) Signed-off-by: Matej Vasek <[email protected]> * chore: update CA certs (#1944) Signed-off-by: Matej Vasek <[email protected]> * chore: update Quarkus platform version to 3.4.1 (#1989) Co-authored-by: Knative Automation <[email protected]> Signed-off-by: Matej Vasek <[email protected]> * chore: update mvn wrapper in Quarkus template (#1987) Signed-off-by: Matej Vasek <[email protected]> * chore: use ./mvnw not mvn in tests (#1988) Signed-off-by: Matej Vasek <[email protected]> * chore: update Springboot platform version Signed-off-by: Matej Vasek <[email protected]> * fix: docker registry/repository parsing (#1929) * fix: docker registry/repository parsing Use go-containerregistry to do parsing. Signed-off-by: Matej Vasek <[email protected]> * fix: use kebab-case instead of camelCase Signed-off-by: Matej Vasek <[email protected]> * fix: use kebab-case instead of camelCase Signed-off-by: Matej Vasek <[email protected]> --------- Signed-off-by: Matej Vasek <[email protected]> * Fix failing concurrent test on Windows (#1890) * src: better debugging Signed-off-by: Matej Vasek <[email protected]> * fix: wait for both builds Signed-off-by: Matej Vasek <[email protected]> * fixup Signed-off-by: Matej Vasek <[email protected]> * fixup Signed-off-by: Matej Vasek <[email protected]> * fixup Signed-off-by: Matej Vasek <[email protected]> * fix: detection of process liveness on Windows Signed-off-by: Matej Vasek <[email protected]> * fix: make symlink relative Signed-off-by: Matej Vasek <[email protected]> * fixup: cleanup Signed-off-by: Matej Vasek <[email protected]> --------- Signed-off-by: Matej Vasek <[email protected]> * allowing on cluster build for go runtime (#1445) * allowing on cluster build for go runtime * warning message added for go and rust builder * gofmt * fixups Signed-off-by: Matej Vasek <[email protected]> --------- Signed-off-by: Matej Vasek <[email protected]> Co-authored-by: Matej Vasek <[email protected]> * Use custom jammy paketo builder (#1911) * chore: use custom jammy paketo builder Use our own modified jammy builder with additional buildpacks for GoFunc and Rust. This enables on cluster build for Go and Rust functions. Where possible (Go, Java) we use "tiny" variant, other runtimes use "base" variant. The updated task is new file instead of modifying existing task this is done for sake of keeping compatiblility. Signed-off-by: Matej Vasek <[email protected]> * fixup: remove unnecessary code per review request Signed-off-by: Matej Vasek <[email protected]> * fixup Signed-off-by: Matej Vasek <[email protected]> * fixup: podman test refers correct tkn task yamls Signed-off-by: Matej Vasek <[email protected]> --------- Signed-off-by: Matej Vasek <[email protected]> * doc: Go and Rust on cluster build is supported (#1923) * doc: Go and Rust on cluster build is supported Signed-off-by: Matej Vasek <[email protected]> * doc: build envvars Signed-off-by: Matej Vasek <[email protected]> --------- Signed-off-by: Matej Vasek <[email protected]> * fix: direct upload ppc64le, x390x (#1958) Signed-off-by: Matej Vasek <[email protected]> * fix: report correct error when task doesn't exist (#1915) Signed-off-by: Matej Vasek <[email protected]> * feat: tekton task urls in the env sub-cmd output (#1925) Signed-off-by: Matej Vasek <[email protected]> --------- Signed-off-by: Matej Vasek <[email protected]> Co-authored-by: Jefferson Ramos <[email protected]> Co-authored-by: Knative Automation <[email protected]> Co-authored-by: Shashank Sharma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
func environment.