Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename knative-sandbox #1905

Merged
merged 4 commits into from
Aug 5, 2023

Conversation

lkingland
Copy link
Member

@lkingland lkingland commented Aug 4, 2023

Renames knative-sandbox to knative-extensions in a few remaining places.

Supersedes #1899

/kind chore

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 4, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2023
@lkingland lkingland requested review from matejvasek, davidhadas and krsna-m and removed request for navidshaikh and dsimansk August 4, 2023 03:32
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.93% 🎉

Comparison is base (7ec31cf) 61.83% compared to head (d2190a6) 62.76%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1905      +/-   ##
==========================================
+ Coverage   61.83%   62.76%   +0.93%     
==========================================
  Files         107      107              
  Lines       13827    13827              
==========================================
+ Hits         8550     8679     +129     
+ Misses       4421     4266     -155     
- Partials      856      882      +26     
Flag Coverage Δ
e2e-test 35.46% <100.00%> (ø)
e2e-test-oncluster 30.71% <100.00%> (+0.02%) ⬆️
e2e-test-oncluster-runtime 25.63% <100.00%> (?)
e2e-test-runtime-go 25.82% <100.00%> (?)
e2e-test-runtime-node 26.90% <100.00%> (?)
e2e-test-runtime-python 26.90% <100.00%> (?)
e2e-test-runtime-quarkus 27.02% <100.00%> (?)
e2e-test-runtime-springboot 26.04% <100.00%> (?)
e2e-test-runtime-typescript 27.02% <100.00%> (?)
integration-tests 51.43% <100.00%> (+2.17%) ⬆️
unit-tests-macos-latest 48.62% <100.00%> (ø)
unit-tests-ubuntu-latest 49.38% <100.00%> (ø)
unit-tests-windows-latest 48.64% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cmd/repository.go 56.33% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidhadas
Copy link
Contributor

/retest

hack/update-builder.go Outdated Show resolved Hide resolved
hack/update-builder.go Outdated Show resolved Hide resolved
@matejvasek
Copy link
Contributor

#1906

@matejvasek
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2023
Makefile Outdated Show resolved Hide resolved
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2023
@matejvasek
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2023
@matejvasek
Copy link
Contributor

@lkingland please check the failing integration test, probably just a flake, but maybe not.

@knative-prow knative-prow bot merged commit 4e0db21 into knative:main Aug 5, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/chore lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants