Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo #1903

Merged
merged 2 commits into from
Aug 3, 2023
Merged

fix: typo #1903

merged 2 commits into from
Aug 3, 2023

Conversation

matejvasek
Copy link
Contributor

No description provided.

Signed-off-by: Matej Vasek <[email protected]>
@matejvasek matejvasek requested a review from krsna-m August 3, 2023 19:45
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2023
@knative-prow knative-prow bot requested review from gauron99 and nainaz August 3, 2023 19:45
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 3, 2023
Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2023
@gauron99
Copy link
Contributor

gauron99 commented Aug 3, 2023

wouldnt it be better like func delete with explicit name as argument or func delete explicitly with name as argument ? not sure if my english is correct here :D

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: +2.18% 🎉

Comparison is base (0a9ed1b) 60.58% compared to head (73453ed) 62.76%.
Report is 205 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1903      +/-   ##
==========================================
+ Coverage   60.58%   62.76%   +2.18%     
==========================================
  Files          75      107      +32     
  Lines       10340    13827    +3487     
==========================================
+ Hits         6264     8679    +2415     
- Misses       3508     4266     +758     
- Partials      568      882     +314     
Flag Coverage Δ
e2e-test 35.46% <ø> (?)
e2e-test-oncluster 30.80% <ø> (?)
e2e-test-oncluster-runtime 25.63% <ø> (?)
e2e-test-runtime-go 25.90% <ø> (?)
e2e-test-runtime-node 26.90% <ø> (?)
e2e-test-runtime-python 26.90% <ø> (?)
e2e-test-runtime-quarkus 27.02% <ø> (?)
e2e-test-runtime-springboot 26.04% <ø> (?)
e2e-test-runtime-typescript 27.02% <ø> (?)
integration-tests 51.43% <ø> (+0.13%) ⬆️
unit-tests ?
unit-tests-macos-latest 48.62% <ø> (?)
unit-tests-ubuntu-latest 49.40% <ø> (?)
unit-tests-windows-latest 48.66% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 96 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2023
@matejvasek
Copy link
Contributor Author

@gauron99 plz lgtm

@gauron99
Copy link
Contributor

gauron99 commented Aug 3, 2023

LGTM

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, matejvasek, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit c565af9 into knative:main Aug 3, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants