Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: update func go runtime dep #1879

Merged
merged 3 commits into from
Jul 25, 2023

Conversation

lkingland
Copy link
Member

🧹 updates func runtime dependency

/kind cleanup

@knative-prow knative-prow bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 19, 2023
@knative-prow knative-prow bot requested review from dsimansk and nainaz July 19, 2023 08:46
@lkingland lkingland requested a review from lance July 19, 2023 08:49
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.76% 🎉

Comparison is base (cb6f33d) 61.80% compared to head (9b59d29) 62.56%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1879      +/-   ##
==========================================
+ Coverage   61.80%   62.56%   +0.76%     
==========================================
  Files         106      106              
  Lines       13777    13777              
==========================================
+ Hits         8515     8620     +105     
+ Misses       4410     4274     -136     
- Partials      852      883      +31     
Flag Coverage Δ
e2e-test 35.48% <ø> (ø)
e2e-test-oncluster 30.56% <ø> (ø)
e2e-test-runtime-go 25.89% <ø> (?)
e2e-test-runtime-node 26.89% <ø> (?)
e2e-test-runtime-python 26.89% <ø> (?)
e2e-test-runtime-quarkus 27.01% <ø> (?)
e2e-test-runtime-springboot 26.00% <ø> (?)
e2e-test-runtime-typescript 27.01% <ø> (?)
integration-tests 51.36% <ø> (+2.15%) ⬆️
unit-tests-macos-latest 49.25% <ø> (+0.02%) ⬆️
unit-tests-ubuntu-latest 50.04% <ø> (ø)
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkingland lkingland added this to the Release 1.11 milestone Jul 19, 2023
@lance
Copy link
Member

lance commented Jul 19, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2023
@matejvasek
Copy link
Contributor

matejvasek commented Jul 20, 2023

@lkingland it looks like newer version of runtime is not Windows compatible.
lkingland/func-runtime-go@0fd4ffe -- the signal is not defined on windows.

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2023
@lkingland
Copy link
Member Author

@lkingland it looks like newer version of runtime is not Windows compatible. lkingland/func-runtime-go@0fd4ffe -- the signal is not defined on windows.

Thanks! I updated the filter to only apply for linux, and to compare by hex

@lkingland lkingland requested review from matejvasek and removed request for lance, dsimansk and nainaz July 21, 2023 06:05
@matejvasek
Copy link
Contributor

@lkingland The TestBuilder_Concurrency test is failing too often at Windows, isn't there really a bug?

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 21, 2023
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2023
@matejvasek
Copy link
Contributor

@lkingland I believe there is really a bug on Windows. I can reproduce it.

@matejvasek
Copy link
Contributor

a) It looks like "normal" user cannot create symlink:

=== RUN   TestBuilder_Concurrency
mkdir -p C:\Users\mvasek\AppData\Local\Temp\TestBuilder_Concurrency1529383575\001\.func\builds\by-hash\b097429205e010f2b4a96d9a80860c0335bd0d961
f761ead9e3ba79396ace1ce
mkdir -p C:\Users\mvasek\AppData\Local\Temp\TestBuilder_Concurrency1529383575\001\.func\builds\by-pid
ln -s ..\by-hash\b097429205e010f2b4a96d9a80860c0335bd0d961f761ead9e3ba79396ace1ce C:\Users\mvasek\AppData\Local\Temp\TestBuilder_Concurrency1529
383575\001\.func\builds\by-pid\8220
test build error symlink ..\by-hash\b097429205e010f2b4a96d9a80860c0335bd0d961f761ead9e3ba79396ace1ce C:\Users\mvasek\AppData\Local\Temp\TestBuil
der_Concurrency1529383575\001\.func\builds\by-pid\8220: A required privilege is not held by the client.panic: test timed out after 10s

b) even when running as an admin there is another issue:

=== RUN   TestBuilder_Concurrency
mkdir -p C:\Users\mvasek\AppData\Local\Temp\TestBuilder_Concurrency1347840251\001\.func\builds\by-hash\d9434b8b4ec1e5e485daa9a248a3c59272b36f0c8
cce8b41d58ef305bae69c56
mkdir -p C:\Users\mvasek\AppData\Local\Temp\TestBuilder_Concurrency1347840251\001\.func\builds\by-pid
ln -s ..\by-hash\d9434b8b4ec1e5e485daa9a248a3c59272b36f0c8cce8b41d58ef305bae69c56 C:\Users\mvasek\AppData\Local\Temp\TestBuilder_Concurrency1347
840251\001\.func\builds\by-pid\19300
→ /func
→ /func/README.md
→ /func/func.yaml
→ /func/go.mod
→ /func/handle.go
→ /func/handle_test.go
mv .\datalayer.tar.gz .\oci\blobs\sha256\2a2c63a63996284d9070f746d9225c6db3f10040404a318d315410e9990a2e01
→ /etc/ssl/certs/ca-certificates.crt
→ /etc/pki/tls/certs/ca-certificates.crt
mv .\certslayer.tar.gz .\oci\blobs\sha256\3650df3d1bb6e357be8bca5bdc04df36f9e3b973fb221d9cdce3193ae10a08c7
rm -rf C:\Users\mvasek\AppData\Local\Temp\TestBuilder_Concurrency1347840251\001\.func\builds\by-hash\d9434b8b4ec1e5e485daa9a248a3c59272b36f0c8cc
e8b41d58ef305bae69c56
test build error remove C:\Users\mvasek\AppData\Local\Temp\TestBuilder_Concurrency1347840251\001\.func\builds\by-hash\d9434b8b4ec1e5e485daa9a248
a3c59272b36f0c8cce8b41d58ef305bae69c56\config.json: The process cannot access the file because it is being used by another process.mv .\config.j
son .\oci\blobs\sha256\f72f75e96f760d68fafd1c64a01752c66f18c5a6a5791f938927b833750d944e
rm C:\Users\mvasek\AppData\Local\Temp\TestBuilder_Concurrency1347840251\001\.func\builds\by-pid\19300
rm C:\Users\mvasek\AppData\Local\Temp\TestBuilder_Concurrency1347840251\001\.func\builds\by-hash\d9434b8b4ec1e5e485daa9a248a3c59272b36f0c8cce8b4
1d58ef305bae69c56
test build error rename C:\Users\mvasek\AppData\Local\Temp\TestBuilder_Concurrency1347840251\001\.func\builds\by-hash\d9434b8b4ec1e5e485daa9a248
a3c59272b36f0c8cce8b41d58ef305bae69c56\config.json C:\Users\mvasek\AppData\Local\Temp\TestBuilder_Concurrency1347840251\001\.func\builds\by-hash
\d9434b8b4ec1e5e485daa9a248a3c59272b36f0c8cce8b41d58ef305bae69c56\oci\blobs\sha256\f72f75e96f760d68fafd1c64a01752c66f18c5a6a5791f938927b833750d9
44e: The system cannot find the path specified.panic: test timed out after 10s

@matejvasek
Copy link
Contributor

It's probably not introduced by this PR but still needs fixing.

@lkingland
Copy link
Member Author

@lkingland I believe there is really a bug on Windows. I can reproduce it.

That's great news you can reproduce!

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 25, 2023
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 25, 2023
@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lance
Copy link
Member

lance commented Jul 25, 2023

/override "Unit Test (1.20.2, 17, windows-latest)"

@knative-prow
Copy link

knative-prow bot commented Jul 25, 2023

@lance: Overrode contexts on behalf of lance: Unit Test (1.20.2, 17, windows-latest)

In response to this:

/override "Unit Test (1.20.2, 17, windows-latest)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit a2834c2 into knative:main Jul 25, 2023
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants