Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update tekton client library #1856

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

matejvasek
Copy link
Contributor

Changes

  • 🧹 Update tekton client library. This prevents possible send on close channel panic.

This prevents `send on closed channel` panic.

Signed-off-by: Matej Vasek <[email protected]>
@knative-prow
Copy link

knative-prow bot commented Jul 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from dsimansk and rhuss July 11, 2023 11:15
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2023
@matejvasek matejvasek requested review from lkingland and removed request for rhuss and dsimansk July 11, 2023 11:15
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.97 🎉

Comparison is base (f671918) 62.52% compared to head (5fcba3f) 63.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1856      +/-   ##
==========================================
+ Coverage   62.52%   63.50%   +0.97%     
==========================================
  Files         107      107              
  Lines       13800    13800              
==========================================
+ Hits         8628     8763     +135     
+ Misses       4348     4189     -159     
- Partials      824      848      +24     
Flag Coverage Δ
e2e-test 35.29% <ø> (ø)
e2e-test-oncluster 31.22% <ø> (ø)
e2e-test-oncluster-runtime 26.67% <ø> (?)
e2e-test-runtime-go 25.62% <ø> (?)
e2e-test-runtime-node 26.71% <ø> (?)
e2e-test-runtime-python 26.71% <ø> (?)
e2e-test-runtime-quarkus 26.82% <ø> (?)
e2e-test-runtime-springboot 25.76% <ø> (?)
e2e-test-runtime-typescript 26.82% <ø> (?)
integration-tests 51.71% <ø> (+3.53%) ⬆️
unit-tests-macos-latest 49.60% <ø> (-0.03%) ⬇️
unit-tests-ubuntu-latest 50.41% <ø> (?)
unit-tests-windows-latest 49.64% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2023
@knative-prow knative-prow bot merged commit ce4b05b into knative:main Jul 11, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants