-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shell executor logs through testing.T in upgrade tests #7367
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7367 +/- ##
==========================================
- Coverage 76.87% 76.84% -0.03%
==========================================
Files 252 252
Lines 13822 13822
==========================================
- Hits 10625 10622 -3
- Misses 2667 2669 +2
- Partials 530 531 +1 ☔ View full report in Codecov by Sentry. |
Printing within test scope can be seen in this run |
Update deps on knative.dev/pkg
This reverts commit 65c557d.
241e333
to
772e0f5
Compare
/test reconciler-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, mgencur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mgencur: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Similar to knative/serving#14495
Fixes #
Proposed Changes
Pre-review Checklist
Release Note
Docs