Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop vendor licenses #864

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

dprotaso
Copy link
Contributor

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2024
@knative-prow knative-prow bot requested review from creydr and psschwei March 27, 2024 16:51
@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 27, 2024
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.23%. Comparing base (742c8a6) to head (a59e96d).

❗ Current head a59e96d differs from pull request most recent head a968646. Consider uploading reports for the commit a968646 to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #864   +/-   ##
=====================================
  Coverage   4.23%   4.23%           
=====================================
  Files         16      16           
  Lines        307     307           
=====================================
  Hits          13      13           
  Misses       294     294           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
@dprotaso
Copy link
Contributor Author

@cardil this needs a re-review

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2024
Copy link

knative-prow bot commented Mar 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 7ee8f66 into knative-extensions:main Mar 28, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants